diegomarvid commented 5 months ago

Tryolabs model implementation

[x] Added a .python-version file to specify python version 3.10.0. It doesn't work if python version is older than 3.10. We need to specify this in the readme.
[x] Updated requirements.txt with new dependencies. gdown will not be necessary at production, but it's handy to download the model while we don't have a model hub.
[x] Deleted open_meteo/open_meteo.py file. It didn't have anything that was used inside the main code.
[x] Created weather/open_meteo.py file for our logic to get Weather Data from Open Meteo.
[x] Created a forecasts/v2.py function that uses tryolabs model.
[x] Updated forecast.py function to use both models based on a provided model file. By default it uses the model OCF saved inside the library.

We need a centralized location where users can download models we will use in the library. This is a good practice. Saving the models inside the library makes it bigger, harder to maintain, and harder to change the models after the library is released.

peterdudfield commented 5 months ago

Let me know @diegomarvid if this is ready for a review yet

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 97.65625% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 79.31%. Comparing base (05ae555) to head (a9f0c79). Report is 16 commits behind head on main.

:exclamation: Current head a9f0c79 differs from pull request most recent head 90b82a3

Please upload reports for the commit 90b82a3 to get more accurate results.

Files	Patch %	Lines
quartz_solar_forecast/weather/open_meteo.py	93.33%	2 Missing :warning:
quartz_solar_forecast/forecast.py	96.77%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #118 +/- ## ========================================== - Coverage 79.94% 79.31% -0.64% ========================================== Files 12 18 +6 Lines 354 551 +197 ========================================== + Hits 283 437 +154 - Misses 71 114 +43 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

peterdudfield commented 4 months ago

Im just looking at your comment in the PR @diegomarvid. We could create a HuggingFace repo, and put the models in there. What do you think?

peterdudfield commented 4 months ago

This looks good to me. @zakwatts do you want a final look at this?

peterdudfield commented 4 months ago

@froukje @diegomarvid you to happy this is finished?

froukje commented 4 months ago

Amazing job everyone! Congratulations! Thanks @peterdudfield and @zakwatts for approving!

peterdudfield commented 4 months ago

@all-contributors please add @froukje for code. please add @diegomarvid for code. please add @Ludecan for review.

allcontributors[bot] commented 4 months ago

@peterdudfield

I've put up a pull request to add @froukje! :tada:

I've put up a pull request to add @diegomarvid! :tada:

I've put up a pull request to add @Ludecan! :tada:

openclimatefix / open-source-quartz-solar-forecast

Upload Tryolabs model #118

Tryolabs model implementation

Codecov Report