openclimatefix / perceiver-pytorch

Implementation of Perceiver, General Perception with Iterative Attention, in Pytorch

MIT License

14 stars 0 forks source link

Change Fourier Encoding to Linear Space #22

Closed jacobbieker closed 3 years ago

jacobbieker commented 3 years ago

Matches the paper closer, based off https://github.com/lucidrains/perceiver-pytorch/issues/52

Pull Request

Description

Apparently the JAX implementation uses linearly spaced Fourier Features, see https://github.com/lucidrains/perceiver-pytorch/issues/52 so this just updates our implementation to do the same

Fixes #

How Has This Been Tested?

Unit tests

[ ] No
[x] Yes

Checklist:

[x] My code follows OCF's coding style guidelines
[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have checked my code and corrected any misspellings