openclimatefix / pv-site-api

Site specific API for PV forecasting
5 stars 8 forks source link

Add Sum #103

Closed peterdudfield closed 5 days ago

peterdudfield commented 10 months ago

Detailed Description

Add a route that gets the sum of forecasts and generations

Context

Possible Implementation

BraunRudolf commented 6 days ago

I'll implement this one.

BraunRudolf commented 6 days ago

Just looked into it, is this still relevant? Both routes

@app.get(
    "/sites/pv_actual",
    response_model=Union[list[MultiplePVActual], list[GenerationSum], MultipleSitePVActualCompact],
    tags=["Generation"],)
)

and

@app.get(
    "/sites/pv_forecast",
    tags=["Forecast"],
)

have the sum_by option which would return the sum (right?) Shall I implement a route that returns both, or can we close this issue?

peterdudfield commented 5 days ago

I think close the issue