rahul-maurya11b commented 3 months ago

Pull Request

Description

updated the sqlachemy >2.0 . by doing the pvsite-model to version 1.0.17 . The lint and format test were giving error so added the dependency of pvsite-model geopandas = "^0.14.2" in pyproject.toml and all test passes.

Fixes #155

How Has This Been Tested?

manually running pytest

[ ] Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

[ ] Yes

Checklist:

[x] My code follows OCF's coding style guidelines
[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have checked my code and corrected any misspellings

rahul-maurya11b commented 3 months ago

sir, do I have to create a PR that aligns with current commits because this commit shows changes of removed warnings that were merged externally?

rahul-maurya11b commented 2 months ago

@peterdudfield sir please review this one also.

rahul-maurya11b commented 2 months ago

@peterdudfield sir i have updated the branch which triggered the CI and test passes.

peterdudfield commented 2 months ago

Amazing, thank you for doing this @rahul-maurya11b

peterdudfield commented 2 months ago

@all-contributors please add @rahul-maurya11b for code

allcontributors[bot] commented 2 months ago

@peterdudfield

I've put up a pull request to add @rahul-maurya11b! :tada:

openclimatefix / pv-site-api

Updated sqlalchemy>2.0 #157

Pull Request

Description

How Has This Been Tested?

Checklist: