openclimatefix / pv-site-api

Site specific API for PV forecasting
5 stars 8 forks source link

Added mechanism to log API requests #161

Closed suleman1412 closed 2 months ago

suleman1412 commented 2 months ago

Pull Request

Description

Implemented saving API calls for user. Updated pvsite-datamodel to 1.0.19, sqlalchemy to 2.0 and geopandas to 0.14.2 as it caused a dependency issue

Fixes #154

How Has This Been Tested?

pytest ran successfully locally

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

Checklist:

sentry-io[bot] commented 2 months ago

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: pv_site_api/cache.py

Function Unhandled Issue
wrapper RuntimeError: dictionary changed size during iteration /sites/pv_...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

suleman1412 commented 2 months ago

@peterdudfield does this work as expected?

peterdudfield commented 2 months ago

Could you add a test to check it works?

peterdudfield commented 2 months ago

Could you add a test to check it works?

Or perhaps I can add a new issue to add tests for this, and then we can get this merge

peterdudfield commented 2 months ago

I had ot run poetry lock --no-update to update the poetry files, which makes everything work nicely now

peterdudfield commented 2 months ago

@all-contributors please add @suleman1412 for code

allcontributors[bot] commented 2 months ago

@peterdudfield

I've put up a pull request to add @suleman1412! :tada: