openclimatefix / pv-site-datamodel

Datamodel for PV sites
MIT License
2 stars 9 forks source link

refactor test_read.py #134

Closed vishalj0501 closed 6 months ago

vishalj0501 commented 6 months ago

Pull Request

Description

Refactor test_read.py - https://github.com/openclimatefix/pv-site-datamodel/blob/main/tests/test_read.py as the file is a it long. This PR makes it more readable, and easy to run a smaller amount of tests.

Fixes #132

Checklist:

vishalj0501 commented 6 months ago

@peterdudfield I've made the changes Thank You

peterdudfield commented 6 months ago

You can see the lint errors here - https://github.com/openclimatefix/pv-site-datamodel/actions/runs/8981594926/job/24667425757

isort --check pvsite_datamodel tests should then solve it

peterdudfield commented 6 months ago

@all-contributors please add @vishalj0501 for test

allcontributors[bot] commented 6 months ago

@peterdudfield

I've put up a pull request to add @vishalj0501! :tada: