search

openclimatefix / pv-site-datamodel

Datamodel for PV sites
MIT License
2 stars 12 forks source link

Remove conversion of datetime string from forecast function #35

Closed devsjc closed 1 year ago

devsjc commented 1 year ago

Incoming dataframe will have datetime objects in the 'target_datetime_utc' column, so remove the parsing occuring in the forecast function.

peterdudfield commented 1 year ago

Do you need to update the tests?

codecov-commenter commented 1 year ago

Codecov Report

Merging #35 (313bf11) into main (6c16ccd) will decrease coverage by 4.63%. The diff coverage is 43.75%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   91.34%   86.72%   -4.63%     
==========================================
  Files          16       16              
  Lines         335      354      +19     
==========================================
+ Hits          306      307       +1     
- Misses         29       47      +18
Impacted Files Coverage Δ
sdk/python/pvsite_datamodel/schema.py 0.00% <ø> (ø)
sdk/python/pvsite_datamodel/write/forecast.py 96.96% <ø> (-0.18%) :arrow_down:
...on/pvsite_datamodel/read/latest_forecast_values.py 53.84% <35.71%> (-46.16%) :arrow_down:
sdk/python/pvsite_datamodel/read/__init__.py 100.00% <100.00%> (ø)
sdk/python/pvsite_datamodel/read/site.py 76.31% <100.00%> (ø)
sdk/python/pvsite_datamodel/sqlmodels.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more