openclimatefix / pv-site-datamodel

Datamodel for PV sites
MIT License
2 stars 10 forks source link

RFC: Consolidate repo #63

Closed simlmx closed 1 year ago

simlmx commented 1 year ago

See individual commits

Basically this removes sdk/python and puts everything at the root, plus some little clean ups here and there.

Let me know if you disagree with some commits.

codecov[bot] commented 1 year ago

Codecov Report

Merging #63 (11080b3) into main (84b10de) will increase coverage by 0.10%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   93.06%   93.17%   +0.10%     
==========================================
  Files           9        9              
  Lines         202      205       +3     
==========================================
+ Hits          188      191       +3     
  Misses         14       14              
Impacted Files Coverage Δ
pvsite_datamodel/connection.py 93.33% <ø> (ø)
pvsite_datamodel/read/__init__.py 100.00% <ø> (ø)
pvsite_datamodel/read/generation.py 93.93% <ø> (ø)
pvsite_datamodel/read/latest_forecast_values.py 100.00% <ø> (ø)
pvsite_datamodel/read/site.py 76.31% <ø> (ø)
pvsite_datamodel/read/status.py 100.00% <ø> (ø)
pvsite_datamodel/write/generation.py 91.66% <ø> (ø)
pvsite_datamodel/__init__.py 100.00% <100.00%> (ø)
pvsite_datamodel/sqlmodels.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

devsjc commented 1 year ago

Looks good to me! I can give up on my dream of writing an sdk in a typed language... 😅