Add site owner - Githubissues

openclimatefix / pv-site-datamodel

Datamodel for PV sites

MIT License

2 stars 10 forks source link

Add site owner #90

Open peterdudfield opened 10 months ago

peterdudfield commented 10 months ago

Detailed Description

Add an optional owner in the site

Context

good to know who the owner is. This could the owner of the site, or where we are pulling the data from
we could create a seperate table for this, but perhaps keeping it simple for the moment is good.

Possible Implementation

Add column to Site
Can be a string
The default can be None

anupamkarn commented 8 months ago

Hi,

I stumbled upon this issue, but I wasn't able to understand the issue here could you please elaborate it a bit more? I am relatively new to open-source contribution and would like to check if I can contribute for it?

Thanks

peterdudfield commented 8 months ago

Hi @anupamkarn , could you add this new feature to https://github.com/openclimatefix/pv-site-datamodel/blob/main/pvsite_datamodel/sqlmodels.py

BraunRudolf commented 5 months ago

Hi @peterdudfield, I could implement this (if still relevant)

Just to be sure, SiteGroupSQL doesn't need an owner column?

peterdudfield commented 5 months ago

Hi @peterdudfield, I could implement this (if still relevant)

Just to be sure, SiteGroupSQL doesn't need an owner column?

Yea that would be great. Yea only in "site"

BraunRudolf commented 5 months ago

@peterdudfield could you elaborate what's the difference between the new field and dno?

owner = sa.Column(sa.String(255), comment="The name of the site owner")
dno = sa.Column(sa.String(255), comment="The Distribution Node Operator that owns the site")