search

openclimatefix / pv-site-prediction

ML experiments and models for pv site forecasting
10 stars 3 forks source link

Add support for Python 3.12 #122

Open Clemo97 opened 2 months ago

Clemo97 commented 2 months ago

Describe the bug

Open-Source-Quartz-Solar-Forecast is dependent on pv-site-prediction. Some dependencies within pv-site-prediction are out of date and not supported by Python 3.12.

To Reproduce

Steps to reproduce the behavior:

  1. Make sure you have Python 3.12 installed and clone Open-Source-Quartz-Solar-Forecast
  2. Run pip install quartz-solar-forecast

Screenshot from 2024-07-09 11-12-40

Screenshot from 2024-07-09 11-14-20

peterdudfield commented 1 month ago

@Clemo97 did this work?

peterdudfield commented 1 month ago

this is needed for https://github.com/openclimatefix/Open-Source-Quartz-Solar-Forecast/issues/93

peterdudfield commented 1 month ago

This might need chaning - https://github.com/openclimatefix/pv-site-prediction/blob/main/pyproject.toml#L13

zakwatts commented 1 month ago

pandas-stubs should now be able to be updated as well: https://github.com/pandas-dev/pandas-stubs/issues/625

Clemo97 commented 1 month ago

@Clemo97 did this work?

It did but unfortunately my computer died before I could push my changes😭 😭, hence why I never made a PR. All that's required is running the "poetry update" commands check poetry docs for that which will fail on some dependencies which you then have to manually adjust their version to one that is compatible to Python 3.12. Pandas-stubs is just the first dependency that's incompatible but there are more, I found like 3 others.

zakwatts commented 1 month ago

Ahhh I do hate it when that happens! Okay, I'll have a look into this again now. Thanks for the effort you have put in!