openclimatefix / pv-site-production

Production service for PV site level forecasts

MIT License

1 stars 2 forks source link

Error raise on 0% of the forecast work #77

Closed aryanbhosale closed 7 months ago

aryanbhosale commented 7 months ago

Pull Request

Description

Please delete the italicised instruction text! Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

[ ] Yes

Checklist:

[x] My code follows OCF's coding style guidelines
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have checked my code and corrected any misspellings

peterdudfield commented 7 months ago

Ill just merge this to development so the tests can run

peterdudfield commented 7 months ago

Thank you @aryanbhosale for doing this work

aryanbhosale commented 7 months ago

Thank you @aryanbhosale for doing this work

My pleasure @peterdudfield ! I'm actually starting off as an open source newbie, found openclimatefix to be doing something very different from the general organizations - there is a cause. I would like to apply to openclimatefix for this year's gsoc. Would you like to mentor me? I want to solve bigger issues Thank you

peterdudfield commented 7 months ago

Thank you @aryanbhosale for doing this work

My pleasure @peterdudfield ! I'm actually starting off as an open source newbie, found openclimatefix to be doing something very different from the general organizations - there is a cause. I would like to apply to openclimatefix for this year's gsoc. Would you like to mentor me? I want to solve bigger issues Thank you

Yea, of course, I'm happy to be your mentor

aryanbhosale commented 7 months ago

Thank you @aryanbhosale for doing this work

My pleasure @peterdudfield ! I'm actually starting off as an open source newbie, found openclimatefix to be doing something very different from the general organizations - there is a cause. I would like to apply to openclimatefix for this year's gsoc. Would you like to mentor me? I want to solve bigger issues Thank you

Yea, of course, I'm happy to be your mentor

Thank you so much! Will keep working on more issues in the upcoming days.

aryanbhosale commented 7 months ago

Hi @peterdudfield , I had some queries regarding the connection of Solar panel inverter (Enphase) to Open Quartz issue. Could we please connect sometime this week?

peterdudfield commented 7 months ago

Hi @peterdudfield , I had some queries regarding the connection of Solar panel inverter (Enphase) to Open Quartz issue. Could we please connect sometime this week?

Ive started to put it in here - https://github.com/openclimatefix/Open-Source-Quartz-Solar-Forecast/issues/59.