openclimatefix / pv-site-production

Production service for PV site level forecasts

MIT License

1 stars 3 forks source link

update sqlalchemy #81

Closed rahul-maurya11b closed 1 month ago

rahul-maurya11b commented 3 months ago

Pull Request

Fixes #79

How Has This Been Tested?

ran make lint and fixed errors to pass the tests

[ ] Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

[ ] Yes

Checklist:

[ ] My code follows OCF's coding style guidelines
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked my code and corrected any misspellings

rahul-maurya11b commented 3 months ago

@peterdudfield sir this fails some tests , I ran make lint in forecast_inference and database_cleanup and fixed errors based on error result but for that I have to set some values to None not sure of that and also it passed locally but fails after pushing gives error : The currently activated Python version 3.10.12 is not supported by the project (^3.11). to solve this I changed some versions to 3.11 still issue persist If I am running pytest using poetry run pytest tests it shows timeout no test ran .. please check what changes I should make?

peterdudfield commented 3 months ago

Could you update to the most recent branch, and then the CI will run. I can then have a look at the failing tests

peterdudfield commented 1 month ago

Thank you, ive included these changes in #84. Ill close this for now