openclimatefix / pv-solar-farm-forecasting

Forecasting for individual solar farms
MIT License
0 stars 0 forks source link

write ukpn data as netcdf #12

Closed vrym2 closed 1 year ago

vrym2 commented 1 year ago

Pull Request

UKPN solar data into NetCDF

Description

This PR corresponds to pre-processing functions and datapipe to write the data into NetCDF

Fixes #

How Has This Been Tested?

Initial tests have been performed to check if the data has been stored as NetCDF, and further tests will be conducted moving forward.

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

Checklist:

vrym2 commented 1 year ago

Looks good! Some comments that might fix some of the tests. But yeah, looks good

pytest locally are working fine! But in the Github actions checks are not getting passed, due to errors, trying to resolve that, will let you know how it goes!