openclimatefix / pvoutput

Python code for downloading PV data from PVOutput.org

Apache License 2.0

34 stars 17 forks source link

Small fixes to allow querying US data #110

Closed rachtsingh closed 2 years ago

rachtsingh commented 2 years ago

Pull Request

Description

The UK country code was hard-coded into one location. Some data in the US is apparently reported using commas (e.g. 1,381.46W) which was confusing the parser. Both are one-line fixes below.

How Has This Been Tested?

Note that this is a bugfix. I ran some of the code in quick_start.ipynb (with modifications for the US) and it seems to work. There are likely other fixes needed, though, querying in the US directly (using pv.search) still doesn't work properly.

rachtsingh commented 2 years ago

Looks like the build failure is due to black not being upgraded, which is addressed in https://github.com/openclimatefix/pvoutput/pull/109. Should work soon, cheers.

peterdudfield commented 2 years ago

Thanks @rachtsingh for doing these fixes for US data, and doing a PR back

@all-contributors please add @rachtsingh for code

allcontributors[bot] commented 2 years ago

@peterdudfield

I've put up a pull request to add @rachtsingh! :tada: