openclimatefix / quartz-frontend

Front End repo for the Nowcasting project.

https://openclimatefix.org/projects/nowcasting/

MIT License

103 stars 16 forks source link

Test removing unneeded api calls #344

Closed braddf closed 10 months ago

braddf commented 1 year ago

Pull Request

Description

Fixes #

How Has This Been Tested?

Preview branch here: https://nowcasting-aas1wfc74-openclimatefix.vercel.app/

[x] Yes

Checklist:

[x] My code follows OCF's coding style guidelines
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have checked my code and corrected any misspellings

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
nowcasting-app	✅ Ready (Inspect)	Visit Preview	Mar 10, 2023 at 3:51PM (UTC)
nowcasting-website	✅ Ready (Inspect)	Visit Preview	Mar 10, 2023 at 3:51PM (UTC)

peterdudfield commented 1 year ago

Sorry @braddf I didnt look at this. This is probably worth doing. Do you mind looking at the merge conflicts? There's a chance this has been done already on staging, if so, shall we close this?

peterdudfield commented 1 year ago

Perhaps @braddf we can close this now? has the work been done in a different branch?

braddf commented 1 year ago

@peterdudfield – I'm not sure it all has actually, it may have, and I think @rachel-labri-tipton's PR to remove the GSP All API call was maybe some of this, and other stuff here may have been refactored and is outdated now, but I'll double check and either update or close this PR 👍

peterdudfield commented 1 year ago

@peterdudfield – I'm not sure it all has actually, it may have, and I think @rachel-labri-tipton's PR to remove the GSP All API call was maybe some of this, and other stuff here may have been refactored and is outdated now, but I'll double check and either update or close this PR 👍

Not sure this helps, but here are all the URL calls from the UI in the last 5 mins (I think from the UI)

braddf commented 1 year ago

Ah grand, from the looks of that we should be okay then; I'll be going through all of this at least once as we make these speed upgrades so happy for this PR to be closed

peterdudfield commented 11 months ago

now out of date?

braddf commented 10 months ago

Closing, think has been merged elsewhere and now out-of-date