search

openclimatefix / quartz-frontend

Front End repo for the Nowcasting project.
https://openclimatefix.org/projects/nowcasting/
MIT License
103 stars 16 forks source link

Switch bit.dev dependency install system #345

Open AndrewLester opened 1 year ago

AndrewLester commented 1 year ago

Pull Request

Description

In this PR I've migrated to using yarn to incorporate bit dependencies. Tailwind with bit just doesn't seem to work on tailwindcss 3, so we'll be using it mostly for config sharing and icon/logo sharing (we're already using it, this just keeps this repo up to date with what's on the bit cloud, note the version bumps for components.).

I also removed the source for the bit component that was still in the repo (layout header). I'm not sure the best practice here, but I think just leaving the source on bit cloud for now won't be much of a problem since there won't be frequent changes to the icons and logo.

To update any of the components, one can just bit import them and push new snapped changes.

I can also replace instances of the source components in this repo to use the bit versions (remove source from this repo and install from bit.dev), like this one for example: https://github.com/openclimatefix/nowcasting/blob/80e7511aeea799cc4103e93ee84a198acc9e0947/apps/nowcasting-app/components/icons/icons.tsx#L16

Also: it's been a while since I've looked into the monorepo setup, so my additions to the root yarn.lock might be unnecessary. Let me know and I can revert that.

How Has This Been Tested?

Currently these bit dependencies are available on the bit cloud, and installed in pv-sites-mobile.

Checklist:

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nowcasting-app ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 25, 2023 at 7:27PM (UTC)
nowcasting-website ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 25, 2023 at 7:27PM (UTC)
peterdudfield commented 1 year ago

@braddf this all good?

braddf commented 1 year ago

@peterdudfield - that's a good question... @AndrewLester, has this gone in already into another branch, and/or did you do it differently in the end..?

AndrewLester commented 1 year ago

@braddf, so this code hasn't gone into another branch in any way, but the code here is the most recent version that I've sent up to the bit cloud with all the components. Additionally, I removed all components stored in bit cloud from this repo to reduce clutter, and they can be added back if necessary (to edit them). Merging this PR won't affect what's in bit cloud (since it's already there), it will just, hopefully, reduce clutter in the repo.