openclimatefix / quartz-frontend

Front End repo for the Nowcasting project.
https://openclimatefix.org/projects/nowcasting/
MIT License
103 stars 16 forks source link

Feat/346 nia national 48 hours => adding datestamp to chart #355

Closed rachel-labri-tipton closed 9 months ago

rachel-labri-tipton commented 1 year ago

Pull Request

Description

With the 48-hour forecast, we're showing 3-4 days of data in the nowcasting charts. This adds a second x-axis with a date to the nowcasting app charts.

The updated axis looks like this:

Screenshot 2023-04-20 at 21 19 26

It was tricky to get the date to look centered under the first x-axis, so would appreciate any feedback or suggestions for positioning the second x-axis under the first x-axis.

Fixes #346

How Has This Been Tested?

This has been tested by running the code locally.

Checklist:

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nowcasting-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2023 5:45pm
nowcasting-website ✅ Ready (Inspect) Visit Preview Nov 22, 2023 5:45pm
peterdudfield commented 1 year ago

Thanks @rachel-labri-tipton for this, it looks good for the screen shot above. Perhaps @braddf can review the code

rachel-labri-tipton commented 9 months ago

The unit tests are a good idea, @peterdudfield. I'll have a look at it today.