Closed rachel-labri-tipton closed 10 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
nowcasting-app | ✅ Ready (Inspect) | Visit Preview | ✅ 1 resolved | Nov 24, 2023 8:01am |
I wonder if the ttxt should be P90 and P10 not 90% and 10% as this is a bit more recognisable that this is a plevel
hey @peterdudfield , Thanks for the feedback. I agree that the P
makes sense, but we're using OCF instead of P because of the discussion in #384.
If there are no values for the plevels, it'll just return nothing.
Pull Request
Description
Updates the formatting for probabilistic numbers in the tooltip. This was discussed here: #384 .
The updated tooltip looks like this. It might be noticeable that the
OCF Forecast
is now in semi-bold because thetextClass
applied wasn't working, so I fixed that as well when I set thetextClass
for the P levels and values.I updated
useFormatChartData
so that it returns 3 probabilistic things:PROBABILISTIC_RANGE
as an array for the area plotted on the chart and thenPROBABILISTIC_UPPER_BOUND
andPROBABILISTIC_LOWER_BOUND
as numbers. This seems repetitive, but when it came to the tooltip, it was easy to just have number values for all tooltip labels.In terms of review, would like to know if all tooltip numbers are still showing correctly.
Fixes #384
How Has This Been Tested?
I ran the code locally.
Checklist: