Closed rachel-labri-tipton closed 5 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
nowcasting-app | ✅ Ready (Inspect) | Visit Preview | 💬 3 unresolved | Jan 17, 2024 10:17am |
Looks really good i like it, Lets get this in with out the yaxis zoom for the moment
thanks for having a look, @peterdudfield! All of these issues are the same for me. I have a couple ideas for fixing the ymax
issue.
Hey @rachel-labri-tipton – looking really good on the y-axis zoom here ⚡ I think I agree with Dan's comments on Vercel, an X to close also makes sense to me, maybe on the top right, but can see how it looks. And getting same bugs with site/GSP as Peter and you have mentioned above – happy to have a look at these together tomorrow maybe if you fancy?
Hey @rachel-labri-tipton, is this PR superseded by the other zoom one now, and if so can we close this to tidy up pending?
Pull Request
Description
This adds the zoom feature to the chart. Currently you can highlight the chart you want to inspect and the main y-axis domain is adjusted based on the maximum y value in the selected set of data.
The Recharts library allows you to highlight a reference area and then redraw the chart boundaries.
I'm wondering if the
RemixLine
could use another prop that would be thezoomYMax
of the chart when a chart is in a zoomed state.Here are a few screenshots of the feature.
Fixes #409
How Has This Been Tested?
I ran the code locally.
Checklist: