openclimatefix / quartz-frontend

Front End repo for the Nowcasting project.
https://openclimatefix.org/projects/nowcasting/
MIT License
100 stars 17 forks source link

Map changing colours #455

Closed peterdudfield closed 4 months ago

peterdudfield commented 5 months ago

Describe the bug

When clicking on a time, the map doesnt stay on the correct colours and seemes to change after about 1 second

0.4.5 - https://nowcasting-qpgkjcwdf-openclimatefix.vercel.app/ 0.4.6 - https://nowcasting-51lbxde6a-openclimatefix.vercel.app/ 0.4.7 - https://nowcasting-cepdnlfxq-openclimatefix.vercel.app/

To Reproduce

Steps to reproduce the behavior:

  1. Go to dev.quartz.solar, or app.quartz.solar
  2. Click on a time 4 hours in the future
  3. wait
  4. See changing map

Expected behavior

Stay on map colour that we expect

peterdudfield commented 5 months ago

Is it worth looking at odd version on Vercel, and seeing if this happens. Then we can narrow it down?

peterdudfield commented 5 months ago

This does not seem a problem in v0.4.5, 0.4.6, 0.4.7 either

peterdudfield commented 4 months ago

On 4.7 i dont see this problem, I note that this only happens once or twice, compare to x10 on live Screenshot 2024-02-19 at 11 54 26

peterdudfield commented 4 months ago

We do see this on dev and on staging and on 0.4.8 - TODO

peterdudfield commented 4 months ago

I do see this locally when running 0.4.8, off c7c2f17

peterdudfield commented 4 months ago

if i comment out

{/*           {!isProduction && ( */}
{/*             <SitesMap */}
{/*               className={currentView(VIEWS.SOLAR_SITES) ? "" : "hidden"} */}
{/*               sitesData={sitesData} */}
{/*               aggregatedSitesData={aggregatedSitesData} */}
{/*               sitesErrors={sitesCombinedErrors} */}
{/*               activeUnit={activeUnit} */}
{/*               setActiveUnit={setActiveUnit} */}
{/*             /> */}
{/*           )} */}
{/*           <DeltaMap */}
{/*             className={currentView(VIEWS.DELTA) ? "" : "hidden"} */}
{/*             combinedData={combinedData} */}
{/*             combinedErrors={combinedErrors} */}
{/*             activeUnit={activeUnit} */}
{/*             setActiveUnit={setActiveUnit} */}
{/*           /> */}

lines in index.tsx it still does it

peterdudfield commented 4 months ago

0.4.7 running locally doesnt show this error

peterdudfield commented 4 months ago

I tried upgrading components, but it didnt seem to help