openclimatefix / quartz-frontend

Front End repo for the Nowcasting project.

https://openclimatefix.org/projects/nowcasting/

MIT License

100 stars 17 forks source link

Feat: global zoom for all charts #456

Closed rachel-labri-tipton closed 3 months ago

rachel-labri-tipton commented 5 months ago

Pull Request

Description

Current code for chart with zoom function that has access to all charts.

Fixes #409

How Has This Been Tested?

Ran the code locally.

Checklist:

[ ] My code follows OCF's coding style guidelines
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked my code and corrected any misspellings

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nowcasting-app	✅ Ready (Inspect)	Visit Preview	✅ 3 resolved	Apr 11, 2024 0:51am
quartz-app	❌ Failed (Inspect)			Apr 11, 2024 0:51am

rachel-labri-tipton commented 3 months ago

hey @braddf, it looks like the zoom has deployed ok. I clicked around and everything seems to be working on the deployed branch. would it be possible to have a look at it and let me know if you're good if it get's merged to dev?

It seems the quartz-frontend has failed to deploy, but will this impact merging these changes to dev?

rachel-labri-tipton commented 3 months ago

hey @braddf, thanks for the feedback. I made the requested changes.