openclimatefix / quartz-frontend

Front End repo for the Nowcasting project.
https://openclimatefix.org/projects/nowcasting/
MIT License
100 stars 17 forks source link

change circle so that area is proportional to expected PV #461

Closed peterdudfield closed 5 months ago

peterdudfield commented 5 months ago

Pull Request

Description

Change the radius of the yellow blob to be

r = expectedpv ^ 0.66.

Note orginally it was r = expectedpv^1, and I tried r = expectedpv ^ 0.5, but something looked a bit wrong. The GSPs that were only at 25% went to half the circle and it looked quite filled out.

Fixes #437

before

Screenshot 2024-01-24 at 21 37 05

now

Screenshot 2024-01-24 at 22 12 36

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

Checklist:

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nowcasting-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2024 9:55pm
rachel-labri-tipton commented 5 months ago

thanks @peterdudfield, this seems to work better.