openclimatefix / quartz-frontend

Front End repo for the Nowcasting project.
https://openclimatefix.org/projects/nowcasting/
MIT License
100 stars 17 forks source link

Issue/466 swap gsp name #467

Open peterdudfield opened 5 months ago

peterdudfield commented 5 months ago

Pull Request

Description

Swap DNO name order

before

Screenshot 2024-05-14 at 13 05 35

now Screenshot 2024-05-14 at 13 05 01

Fixes #466

How Has This Been Tested?

Looked at the new vercel branch + added some unit tests

Checklist:

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nowcasting-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 0:08am
1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **quartz-app** | ⬜️ Ignored ([Inspect](https://vercel.com/openclimatefix/quartz-app/9aqvQ4gc27MFe3jXRFU6sEM3NPuR)) | [Visit Preview](https://quartz-app-git-issue-466-swap-gsp-name-openclimatefix.vercel.app) | | May 14, 2024 0:08am |
rachel-labri-tipton commented 5 months ago

hi @peterdudfield, I'm just having a look at this and wondering what the difference is between SSE and Southern (SSE). I probably just don't know the DNO's well enough.

peterdudfield commented 5 months ago

hi @peterdudfield, I'm just having a look at this and wondering what the difference is between SSE and Southern (SSE). I probably just don't know the DNO's well enough.

Yea, I'm not sure either

https://github.com/openclimatefix/quartz-frontend/issues/466

I've put all the names from the api in this issue

peterdudfield commented 2 months ago

@peterdudfield Is this new name format function intentionally trimming to Region names to only the first word? E.g. WPD (South West) becomes South (WPD) which is not quite the same information

ah good spot, not I think it lost a word there somewhere. Let me fix that