Pull Request

Description

Fix for bug where map flashes data/colours in and out after initial load and on various data change states. Issue was down to the way the data update function in the map was being called, whereby I had added a timeout to wait for the map styles to be initialised and be ready for the data, but in so doing had allowed this to be called repeatedly and introduce runaway spamming of the update function. Now, if it is already waiting for the map to init, it shouldn't create another timeout.

Fixes #455

How Has This Been Tested?

[x] Vercel preview branch
[x] UAT (below)

UAT

Probabilistic Charts

[x] Shading appears around the lines.
[x] Plevel values in the tooltip are 0.0 or above.
[x] Probabilistic range shading and tooltip values appear on the DeltaView charts.

Quartz-specific points

[x] Does the logo look like the new Quartz logo?
[x] Does the logo link to the new Quartz website?
[x] Is the OCF logo present in the logo area?
[x] Does the OCF logo link to the OCF website?
[x] Does the Documentation link go to the new Quartz docs?

PV Forecast

National

[x] Does PV live estimate show on the plot? (black dashed)
[x] Does PV live updated show on the plot? (black solid)
[x] Does OCF forecast show up on plot? (yellow)
[x] For OCF forecast, is the future a dashed line?
[x] Can I hover on the plot to show the values on the plot?
[x] Does the data look like solar profiles?
[x] Clicking on a GSP makes the GSP plot show up?
[x] Clicking on a GSP when already selected, makes the GSP plot go away?
[x] Can I click on a time in the national plot which then updates the map?
[x] Can I click on a past time in the GSP plot which then updates the map?
[x] Can I click on a future time in the GSP plot which then updates the map? – [expected; PVnet only runs 8h ahead for GSPs]
[x] Are values higher on the map in the middle of the day, compared to early morning?

Time

[x] Is time now in Europe London time? It should be to the nearest 30 minute, rounded up.
[x] Is the hover time in Europe London time?
[x] Are the X axis in Europe London time?
[x] Does the data show yesterday as well?
[x] Does the data show tomorrow as well?

Header

[x] Is this the title clear it is National data?
[x] Does the headline current estimated PV figure display?
[x] Does it show the current Forecasted value?
[x] Does the next forecast figure display?
[x] Are the units GW?

GSP

[x] Does PV live estimate show on the plot? (dashed black)
[x] Does PV live updated show on the plot? (solid black)
[x] Does OCF forecast show up on plot? (yellow)
[x] For OCF forecast, is the future a dashed line?
[x] Can I hover on the plot to show the values on the plot?
[x] Does the data look like solar profiles?

Time

[x] Is time now in Europe London time?
[x] Is the hover time in Europe London time?
[x] Are the X axis in Europe London time?

Title

[x] Does the GSP name show up?
[x] Is the current estimated PV visible?
[x] Is the next forecast figure visible?
[x] Are the above figures in MW?

Map

[x] Does a map of the UK show up?
[x] Are the GSP boundaries displayed?
[x] Can I click on '%', 'MW' and 'Capacity'
[x] on 'Capacity' view, is there very little power in Scotland, and Melksham a shining beacon of renewables?

Four Hour View

National

[x] Does the "4hr forecast" toggle show in the Profile Dropdown menu?
Toggle on
- [x] Does the 4hr forecast show up on the plot? (orange)
- [x] Does the 4hr future forecast show up on the plot? (dashed orange)
- [x] Does the 4hr forecast not show on the chart or tooltip when switched off?
Toggle off
- [x] Does the 4hr forecast not show on the chart or tooltip when switched off?
- [x] Does the 4hr future forecast not show on the chart or tooltip when switched off?
[x] Does the 4hr forecast toggle persist across refreshes/logouts using cookie?
[x] Do the 4hr forecast values show in the hover tooltip?

Delta View

National

[x] Does PV live estimate show on the plot? (black dashed)
[x] Does PV live updated show on the plot? (black solid)
[x] Does OCF forecast show up on plot? (yellow)
[x] For OCF forecast, is the future a dashed line?
[x] Does the 4-hour forecast not show on the chart or tooltip when switched off?
[x] Does the 4-hour future forecast not show on the chart or tooltip when switched off?
[x] Does the 4-hour forecast show on the chart and tooltip when switched on?
[x] Can I hover on the plot to show the values on the plot?
[x] Does the data look like solar profiles?
[x] Clicking on a GSP makes the GSP plot show up?
[x] Clicking on a GSP when already selected, makes the GSP plot go away?
[x] Can I click on a time in the national plot which then updates the map?
[x] Can I click on a time in the GSP plot which then updates the map?
[x] Are values higher on the map in the middle of the day, compare to early morning?

Time

[x] Is time now in Europe London time? It should be 30minute, but rounded up.
[x] Is the hover time in Europe London time?
[x] Are the X axis in Europe London time?
[x] Does the data show yesterday as well?

Header

[x] Is this the title clear it is National data?
[x] Does the headline current estimated PV figure display?
[x] Does it show the current Forecasted value?
[x] Does the next forecast figure display?
[x] Are the units GW?

GSP

[x] Does PV live estimate show on the plot? (dashed black)
[x] Does PV live updated show on the plot? (solid black)
[x] Does OCF forecast show up on plot? (yellow)
[x] For OCF forecast, is the future a dashed line?
[x] Can I hover on the plot to show the values on the plot?
[x] Does the data look like solar profiles?

Time

[x] Is time now in Europe London time?
[x] Is the hover time in Europe London time?
[x] Are the X axis in Europe London time?

Title

[x] Does the GSP name show up?
[x] Is the latest forecast figure visible?
[x] Is the next forecast figure visible? [not currently shown for space reasons]
[x] Is the current GSP delta figure visible?
[x] Are the above figures in MW?
[x] Is the Delta block background colour correct, i.e. pos/neg delta colour scheme?

Map

[x] Does a map of the UK show up?
[x] Are the GSP boundaries displayed?
[x] Where Deltas are available, do the correct colours for the GSP delta buckets display and match the table?

Combined views

[x] Does selectedGSP persist when switching between PV Forecast and Delta Views
[x] Does selectedTime persist when switching between PV Forecast and Delta Views
[x] Does map location/zoom persist when switching between PV Forecast and Delta Views

Dashboard Mode

[x] Does the Dashboard Mode toggle show in the Profile Dropdown menu?
[x] Does the Dashboard Mode toggle persist across refreshes/logouts using cookie?

National

[x] Do the National title and forecast values show in large font?
[x] Are the lines on the chart thicker?

GSP

[x] Do the GSP title and forecast values show in large font?
[x] Are the lines on the chart thicker?

Legend

[x] Is the legend larger?
[x] Do the legend items space nicely?

Map

[x] Is the map legend larger?
[x] Are the MW/%/Capacity buttons larger?
[x] Are the date/time larger?

General

[x] is the version visible?
[x] has the version been bumped?
[x] Does the feedback button work?
[x] Is the legend visible
[x] Is the database stable, check on AWS

Auth

[x] Can I log on with Auth?
[x] Can i log out?

Refresh

[x] After 10 mins, does the forecast update?
[ ] After 10 mins, does the forecast creation time update? - No, isn't shown anymore

Documentation

[ ] Update documentation - https://openclimatefix.notion.site/Quartz-Solar-Documentation-0d718915650e4f098470d695aa3494bf
[ ] Do we need to email the users - No

Checklist:

[x] My code follows OCF's coding style guidelines
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have checked my code and corrected any misspellings

Name	Status	Preview	Updated (UTC)
nowcasting-app	✅ Ready (Inspect)	Visit Preview	Feb 28, 2024 5:03pm
quartz-app	❌ Failed (Inspect)		Feb 28, 2024 5:03pm

openclimatefix / quartz-frontend

v0.4.9: Map colour data bugfix #477

Pull Request

Description

How Has This Been Tested?

UAT

Probabilistic Charts

Quartz-specific points

PV Forecast

National

Time

Header

GSP

Time

Title

Map

Four Hour View

National

Delta View

National

Time

Header

GSP

Time

Title

Map

Combined views

Dashboard Mode

National

GSP

Legend

Map

General

Auth

Refresh

Documentation

Checklist: