openclimatefix / quartz-frontend

Front End repo for the Nowcasting project.

https://openclimatefix.org/projects/nowcasting/

MIT License

103 stars 16 forks source link

Add chart max domain calc function & tests #510

Open braddf opened 5 months ago

braddf commented 5 months ago

Pull Request

Description

Fixes #509

How Has This Been Tested?

In local UI with Wind/Solar toggled on and off, and unit tests

[x] Yes

Checklist:

[x] My code follows OCF's coding style guidelines
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have checked my code and corrected any misspellings

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nowcasting-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 8, 2024 10:22am
quartz-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 8, 2024 10:22am

peterdudfield commented 4 months ago

Thanks code looks all good.

One thing I notice when i clikc ont he preview branch is the current view wind wind and solar, the ticks go from 0, 1500, 3000 to 5000. This seems weird? The dev branch is different. Is this something we can sort?

peterdudfield commented 4 months ago

Im not sure if its easy, but should you split this PR in two,

getting CI tests working
adjusting the max domain calc