openclimatefix / quartz-frontend

Front End repo for the Nowcasting project.

https://openclimatefix.org/projects/nowcasting/

MIT License

99 stars 17 forks source link

Quartz Energy v0.1.1 – Auth + Forecast Horizon Select #523

Closed braddf closed 2 weeks ago

braddf commented 2 weeks ago

Pull Request – RELEASE

Features and Changes

Add Auth to Quartz Energy
- Fixes #504
Add feature to select forecast horizon in Quartz Energy UI
- Fixes #519

Caveats and Dependencies

[x] Auth vars need to be set for production environment in Vercel, to the same as the Preview – staging environment vars.

How Has This Been Tested?

Locally against local and dev APIs, and on dev deploy and staging deploy

[x] Yes

Checklist:

[x] My code follows OCF's coding style guidelines
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have checked my code and corrected any misspellings

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
quartz-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 20, 2024 8:16am

1 Ignored Deployment

peterdudfield commented 2 weeks ago

anything changed on nowcasting-app? node CI build failing?

peterdudfield commented 2 weeks ago

Could you add in the PR descirption a link to the github issue for auth?

braddf commented 2 weeks ago

@peterdudfield Yep all good re the above:

minimal changes to nowcasting-app files to allow it to build/render consistently (server- vs. client-side rendering issue), but if it builds it should be identical as is just about how the imports are happening;
the Node CI will fail at the moment until I finish getting the end-to-end (Cypress) tests working in the CI, hopefully soon as I think I worked out the commands a few weeks ago.

braddf commented 2 weeks ago

N.B. preview branches are currently being funny with the Auth redirect, so I may have done that differently to nowcasting-app as they try to redirect back to the AUTH0_BASE_URL if set, i.e. staging.quartz.app in this case, which is not where it came from... I'll check it out in a bit, but the main staging URL on the proper subdomain works fine because it's explicitly set. 👍