openclimatefix / skillful_nowcasting

Implementation of DeepMind's Deep Generative Model of Radar (DGMR) https://arxiv.org/abs/2104.00954

MIT License

219 stars 59 forks source link

fix issue #19 #20

Closed johmathe closed 2 years ago

johmathe commented 2 years ago

Pull Request

Description

this is an attempt at fixing #19

How Has This Been Tested?

Added a test in test_model.py

[x] Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

no data processing changes

Checklist:

[x] My code follows OCF's coding style guidelines
[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have checked my code and corrected any misspellings

peterdudfield commented 2 years ago

@all-contributors please add @johmathe for code

allcontributors[bot] commented 2 years ago

@peterdudfield

I've put up a pull request to add @johmathe! :tada: