openclimatefix / skillful_nowcasting

Implementation of DeepMind's Deep Generative Model of Radar (DGMR) https://arxiv.org/abs/2104.00954
MIT License
214 stars 59 forks source link

Fix inplace operation errors #21

Closed jacobbieker closed 2 years ago

jacobbieker commented 2 years ago

Pull Request

Description

Tests were not using backward passes, and apparently there are issues inplace operations causing backward passes to fail. This should fix it, although does make the model quite a bit bigger.

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

Checklist: