openclimatefix / skillful_nowcasting

Implementation of DeepMind's Deep Generative Model of Radar (DGMR) https://arxiv.org/abs/2104.00954
MIT License
211 stars 59 forks source link

Fix #27 #28

Closed jacobbieker closed 2 years ago

jacobbieker commented 2 years ago

Pull Request

Description

Fixes issue with the splitting dimension for the discriminator loss

Fixes #27

How Has This Been Tested?

Unit tests

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

Checklist:

codecov-commenter commented 2 years ago

Codecov Report

Merging #28 (c0e1add) into main (0fa7c74) will decrease coverage by 0.26%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
- Coverage   71.37%   71.11%   -0.27%     
==========================================
  Files          12       12              
  Lines         807      810       +3     
==========================================
  Hits          576      576              
- Misses        231      234       +3     
Impacted Files Coverage Δ
dgmr/dgmr.py 49.10% <0.00%> (-1.36%) :arrow_down:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more