openclimatefix / skillful_nowcasting

Implementation of DeepMind's Deep Generative Model of Radar (DGMR) https://arxiv.org/abs/2104.00954
MIT License
223 stars 59 forks source link

About the metrics used in the original paper, e.g., CSI, PSD, CPRS? #31

Open GreenLimeSia opened 2 years ago

GreenLimeSia commented 2 years ago

Dear @jacobbieker: Thanks for your excellent work for DGMR. I have some questions about the metrics used in the original paper. Do you have any plans to add these metrics to the script?

Thanks and best regards.

jacobbieker commented 2 years ago

Hi, glad you like this work! I hadn't thought about adding the metrics, but probably will at some point either here, or in HuggingFace Evaluate to have it be more general. But also, happy to accept any PRs or anything adding those too!

GreenLimeSia commented 2 years ago

Thanks for your reply. I will try to do it. Thanks and best regards.

jacobbieker commented 2 years ago

Thanks! Looking forward to seeing your work, and if I can help in anyway, just shout!

peterdudfield commented 2 years ago

@all-contributors please add @GreenLimeSia for question

allcontributors[bot] commented 2 years ago

@peterdudfield

I've put up a pull request to add @GreenLimeSia! :tada: