search

openclimatefix / skillful_nowcasting

Implementation of DeepMind's Deep Generative Model of Radar (DGMR) https://arxiv.org/abs/2104.00954
MIT License
215 stars 59 forks source link

Extra ReLU in L Block #49

Open najeeb-kazmi opened 1 year ago

najeeb-kazmi commented 1 year ago

https://github.com/openclimatefix/skillful_nowcasting/blob/e2d601a377613b463fcc3c7319017f8051346e8e/dgmr/common.py#L280

I believe this first ReLU should not be present in the L Block, going by the diagram in the paper (Extended Data Figure 1, page 18).

peterdudfield commented 1 year ago

Thanks @najeeb-kazmi for the question. I'll let @jacobbieker get back to you on this

peterdudfield commented 1 year ago

@all-contributors please add @najeeb-kazmi for question

allcontributors[bot] commented 1 year ago

@peterdudfield

I've put up a pull request to add @najeeb-kazmi! :tada: