agijsberts commented 5 months ago

Pull Request

Description

DGMR and NowcastingModelHubMixin in their present form are incompatible with huggingface-hub>=0.22, causing a KeyError: 'config' when trying to load the model with model = DGMR.from_pretrained("openclimatefix/dgmr"). This PR pins huggingface-hub to the latest working version for the moment, until a full solution can be developed.

Fixes https://github.com/openclimatefix/skillful_nowcasting/issues/68

How Has This Been Tested?

Checked that the package installs and model loads as expected.

Checklist:

[ ] My code follows OCF's coding style guidelines
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked my code and corrected any misspellings

peterdudfield commented 5 months ago

@all-contributors please add @agijsberts for code

allcontributors[bot] commented 5 months ago

@peterdudfield

I've put up a pull request to add @agijsberts! :tada:

openclimatefix / skillful_nowcasting

Pin huggingface-hub to version 0.21.4 #69

Pull Request

Description

How Has This Been Tested?

Checklist: