search

openclimatefix / skillful_nowcasting

Implementation of DeepMind's Deep Generative Model of Radar (DGMR) https://arxiv.org/abs/2104.00954
MIT License
211 stars 59 forks source link

Fix CI testing #71

Closed peterdudfield closed 2 months ago

peterdudfield commented 2 months ago

Current CI tests dont work. Would someone be able to fix this?

Mews commented 2 months ago

I think this is an issue with the github action you're using https://github.com/openclimatefix/.github/blob/main/.github/workflows/python-test.yml Looks like they're trying to use a linux command on mac-os. You can just not test on macos-latest, but I can write a new workflow that will replace the functionality of the one you were using previously. I'll open a pr when I finish it

peterdudfield commented 2 months ago

To keep the code as simple as possible, maybe its worth just turning of the CI for the mac This can be done with this option - https://github.com/openclimatefix/.github/blob/main/.github/workflows/python-test.yml#L25

Mews commented 2 months ago

Yeah I mean you pick the solution you see fit. I've opened the pr with the new workflow either way if you want to keep testing on mac.

peterdudfield commented 2 months ago

I think i would prefer just turning the CI off for mac, keeps things nice and simple and then we are reusing some of the CI code.

Would you @Mews be interested in doing that?

Mews commented 2 months ago

Alrighty :P

Mews commented 2 months ago

I'm gonna close my other pr then 👍