Closed rutkovskii closed 2 weeks ago
@jacobbieker Hi Jacob, Here is the comment on this PR. https://github.com/openclimatefix/skillful_nowcasting/issues/59#issuecomment-2486632896
@jacobbieker Glad to help! I believe only you can merge it into the main branch from here.
@jacobbieker would it be possible to add me to the list of contributors?
I am also looking to cite this repository in my thesis, and additing the CITATION.cff
file could be useful for others who would be citing your work in the future.
https://citation-file-format.github.io/
https://citation-file-format.github.io/cff-initializer-javascript/#/
@jacobbieker would it be possible to add me to the list of contributors?
I am also looking to cite this repository in my thesis, and additing the
CITATION.cff
file could be useful for others who would be citing your work in the future. https://citation-file-format.github.io/ https://citation-file-format.github.io/cff-initializer-javascript/#/
Yes, of course! The comment above should trigger the bot. I've also added a CITATION.cff
file now too, so hopefully that helps!
@all-contributors please add @rutkovskii for code
@jacobbieker
I've put up a pull request to add @rutkovskii! :tada:
Thank you very much!
Pull Request
Description
This pull request introduces several enhancements and fixes to the DGMR project, focusing on optimization, logging, and data processing. The key updates include:
Memory Optimization:
self.forward
withtorch.utils.checkpoint.checkpoint
to enable gradient checkpointing and reduce memory consumption during training. Added by colleague – @xuzhe951024Improved Logging:
run.py
and restructured logger initialization for simplicity to prevent initialization of multiple loggers in multigpu environemnt..Data Loading Enhancements:
TFDataset
initialization to includetrust_remote_code
for compatibility with remote dataset loading.Code Cleanup:
__main__
block for better readability and modularity.Dependencies:
wandb
,datasets
, andtensorflow
torequirements.txt
to support new functionalities.Fixes # (Include the relevant issue ID if applicable)
How Has This Been Tested?
The changes were tested using the following methods:
fast_dev_run
successfully on MacBook Pro M2.generation step = 6
,batch size = 16
, andprecision = 32
on NVidia A100-80GB.Steps to reproduce:
requirements.txt
.run.py
script with the default configuration.Have you plotted any changes?
Checklist: