openclimatefix / uk-pv-national-gsp-api

API for hosting nowcasting solar predictions
MIT License
6 stars 9 forks source link

Feedback: API inconsistencies #160

Open dctanner opened 1 year ago

dctanner commented 1 year ago
  1. gsp: 0 is used for the national forecast. However when requesting https://api.nowcasting.io/v0/solar/GB/national/pvlive it returns gsp: null instead of gsp: 0
  2. Different energy units are used in different endpoints. E.g. https://api.nowcasting.io/v0/solar/GB/national/forecast returns values in Mw, but https://api.nowcasting.io/v0/solar/GB/national/pvlive returns them in Kw.
peterdudfield commented 1 year ago

For 1. I can fix that, but I wondering what the correct value should be. In the past gsp=0 for national was confusing, so is gsp=null actually better. Or perhaps the better solution is to remove the gsp field for this.

  1. That has grown up from PVlive giving the data in kw and most pv system wokring in kw. But the forecast seem right to give in mw. particualy the national would seem a bit funny in kw / slash harder to read. Its quite some task to change things in the back end (but possible), perhaps the simple solution is to just change pvlive to MW in the api.

What do you think?