openclimatefix / uk-pv-national-gsp-api

API for hosting nowcasting solar predictions
MIT License
6 stars 9 forks source link

Add BMRS national end point #346

Closed peterdudfield closed 6 days ago

peterdudfield commented 1 month ago

Detailed Description

Add a national end point, that provides elexon BMRS solar foreacsts

Context

Possible Implementation

14Richa commented 1 month ago

Hey @peterdudfield , I can work on this issue.

braddf commented 1 month ago

Nice! Does /v0/solar/GB/national/bmrs maybe make more sense? Obv these routing rules weren't made with extra forecasts in mind at the time, but being almost as a sub-route of our forecast feels semantically odd to me 😅

peterdudfield commented 1 month ago

yea, interesting one. Just to note that BMRS is a forecast, so maybe we could have /v0/solar/GB/national/bmrs/forecast or something like that

peterdudfield commented 6 days ago

@all-contributors please add @14Richa for code

allcontributors[bot] commented 6 days ago

@peterdudfield

I've put up a pull request to add @14Richa! :tada: