openclimatefix / uk-pv-national-xg

National PV forecasting using Gradient Boosted Methods.

4 stars 3 forks source link

Issue/night zeros #32

Closed peterdudfield closed 1 year ago

peterdudfield commented 1 year ago

Pull Request

Description

Filter out night time using sun elevation angle
add tests,
functions are copied over from 'nowcasting_forecast' and 'nowcasting_dataset'

Fixes #27

How Has This Been Tested?

added tests + normal CI tests

[x] Yes

Checklist:

[x] My code follows OCF's coding style guidelines
[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have checked my code and corrected any misspellings