openclimatefix / uk-pv-national-xg

National PV forecasting using Gradient Boosted Methods.

4 stars 3 forks source link

Tom/productionizing #4

Closed thomasarmstrong98 closed 1 year ago

thomasarmstrong98 commented 1 year ago

Pull Request

Description

Fixes #3

How Has This Been Tested?

[ X ] Yes

Checklist:

[X ] My code follows OCF's coding style guidelines
[ X] I have performed a self-review of my own code
[ X] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ X] I have checked my code and corrected any misspellings

Tests still TODO, wanted to check that this was inline with what we discussed.

thomasarmstrong98 commented 1 year ago

@peterdudfield see scripts/inference/mock_data_feed.py for offline version using GCP data

thomasarmstrong98 commented 1 year ago

@peterdudfield comments addressed, see scripts/inference/mock_setup.py ( https://github.com/openclimatefix/gradboost_pv/blob/tom/productionizing/scripts/inference/mock_setup.py ) for a run over 2 days.

Although it's not offline script - still fetches the data via GCP, do you have something else in mind?

peterdudfield commented 1 year ago

@peterdudfield comments addressed, see scripts/inference/mock_setup.py ( https://github.com/openclimatefix/gradboost_pv/blob/tom/productionizing/scripts/inference/mock_setup.py ) for a run over 2 days.

Although it's not offline script - still fetches the data via GCP, do you have something else in mind?

This is fine for this task, your next task on here will require you to make it work offline