openclimatefix / uk-pv-national-xg

National PV forecasting using Gradient Boosted Methods.
4 stars 3 forks source link

remove sde and save to s3 #48

Closed peterdudfield closed 1 year ago

peterdudfield commented 1 year ago

Pull Request

Description

Remove sde variable.

Ran results to see the effects of not having 'sdewhen it is trained withsde`. It was better to remove it, and train again

Alos saved new models to s3

Fixes #

How Has This Been Tested?

CI tests

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Merging #48 (6d30ee6) into main (8020372) will decrease coverage by 0.14%. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   43.18%   43.05%   -0.14%     
==========================================
  Files          21       21              
  Lines         947      950       +3     
==========================================
  Hits          409      409              
- Misses        538      541       +3     
Impacted Files Coverage Δ
gradboost_pv/models/s3.py 0.00% <0.00%> (ø)
gradboost_pv/preprocessing/region_filtered.py 72.58% <ø> (ø)
gradboost_pv/__init__.py 100.00% <100.00%> (ø)
gradboost_pv/save.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more