openclimatefix / uk-pv-national-xg

National PV forecasting using Gradient Boosted Methods.
4 stars 3 forks source link

add smoother and test #54

Open peterdudfield opened 1 year ago

peterdudfield commented 1 year ago

Pull Request

Description

Smooth results from models. This make less spiky results. This is because he models don't know about each other.

Fixes #

How Has This Been Tested?

Added a test

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Merging #54 (4130e83) into main (df2a642) will increase coverage by 0.39%. The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   43.05%   43.45%   +0.39%     
==========================================
  Files          21       21              
  Lines         950      962      +12     
==========================================
+ Hits          409      418       +9     
- Misses        541      544       +3     
Impacted Files Coverage Δ
gradboost_pv/app.py 0.00% <0.00%> (ø)
gradboost_pv/__init__.py 100.00% <100.00%> (ø)
gradboost_pv/inference/utils.py 97.22% <100.00%> (+0.92%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

peterdudfield commented 1 year ago

Hold fire on this, until we see jagged results again. The results are a bite smoother right now as we interpolate to 30 mins for each run of the forecast