openclimatefix / uk-pv-national-xg

National PV forecasting using Gradient Boosted Methods.
4 stars 3 forks source link

make bucket name flexible on env #67

Closed peterdudfield closed 1 year ago

peterdudfield commented 1 year ago

Pull Request

Description

make bucket name flexible on env, ready for production

How Has This Been Tested?

CI tests

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Merging #67 (52da81d) into main (b260066) will decrease coverage by 0.05%. The diff coverage is 25.00%.

:exclamation: Current head 52da81d differs from pull request most recent head bb21d02. Consider uploading reports for the commit bb21d02 to get more accurate results

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
- Coverage   43.45%   43.41%   -0.05%     
==========================================
  Files          21       21              
  Lines         955      956       +1     
==========================================
  Hits          415      415              
- Misses        540      541       +1     
Impacted Files Coverage Δ
gradboost_pv/models/s3.py 0.00% <0.00%> (ø)
gradboost_pv/__init__.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more