openclimatefix / uk-pvnet-app

Application for running PVNet in production
MIT License
1 stars 5 forks source link

Refactor data.py #109

Closed peterdudfield closed 1 month ago

peterdudfield commented 1 month ago

Detailed Description

Current the pvnet_app/data.py has a lot of functions. It might be good to split this up

We current have

Context

good to keep things clean Might be good to wait for #108

Possible Implementation

We could split this into pvnet_app/data/satellite.py and pvnet_app/data/nwp.py file.

Similiar for the tests

DivyamAgg24 commented 1 month ago

Hi, I hope this finds you well. I have created a branch named refactor-data.py and made the changes mentioned in this issue. The changes include creating a data folder and within in satellite.py and nwp.py with appropriate functions from data.py. The changes to imports in test_data.py have also been made

peterdudfield commented 1 month ago

Amazing @DivyamAgg24 - could you make a PR to this repo?

DivyamAgg24 commented 1 month ago

I have created a pull request to this Repo

peterdudfield commented 1 month ago

Thank you @DivyamAgg24 for this