openclimatefix / uk-pvnet-app

Application for running PVNet in production
MIT License
1 stars 4 forks source link

issue #109 refactor data.py #110

Closed DivyamAgg24 closed 3 months ago

DivyamAgg24 commented 3 months ago

Pull Request

Description

The pvnet_app/data.py had multiple functions in it. A new folder within pvnet_app called data is created and within it two files: satellite.py and nwp.py are made, each having appropriate functions from the previous data.py. Appropriate changes to test have also been made to ensure that there are no errors during imports from pvnet_app/data/satellite and pvnet_app/data/nwp

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

Checklist:

peterdudfield commented 3 months ago

Ive just updated the repo so it runs on numpy>2. Have you been able to run the tests locally? Looks like there might be some relative path dependencies - https://github.com/openclimatefix/pvnet_app/actions/runs/10139748337/job/28033615438#step:6:111

DivyamAgg24 commented 3 months ago

I tried changing the relative path problems which was in nwp.py

peterdudfield commented 3 months ago

@all-contributors please add @DivyamAgg24 for code

allcontributors[bot] commented 3 months ago

@peterdudfield

I've put up a pull request to add @DivyamAgg24! :tada: