openclimatefix / uk-pvnet-app

Application for running PVNet in production
MIT License
1 stars 4 forks source link

Add day ahead model config #86

Closed Sukh-P closed 5 months ago

Sukh-P commented 5 months ago

Pull Request

Description

Changes to run a separate day ahead PVNet model, which will be deployed alongside the existing intraday PVNet ones. To run the new model a new env variable called DAY_AHEAD_MODEL will need to be added and set to "True".

Some linting has also been applied, will comment on actual changes for clarity

How Has This Been Tested?

Added a test to the test_app file

Checklist:

peterdudfield commented 5 months ago

Looks great, have your run the app locally? That might be the final step before we merge?

Sukh-P commented 5 months ago

Looks great, have your run the app locally? That might be the final step before we merge?

Thanks, trying to get it the tests in test_app.py to run/pass locally currently which feels like a sufficient test since this is running the app locally basically, but if you had something else in mind @peterdudfield let me know. I am running into some errors related to the NWP zarr coords (seemingly unrelated to the changes I have made) that the CI doesn't seem to encounter so just digging into why that is