search

openclimatefix / website

Source of the Open Climate Fix website.
https://openclimatefix.org
MIT License
15 stars 11 forks source link

Add cloud video as iframe #25

Closed sukhbeersingh closed 5 years ago

sukhbeersingh commented 5 years ago

What has been changed Added iframe element to the top of nowcasting page.

Why was the change necessary Fix issue #14

Please let me know if the position looks good. Putting it on the top provides instantaneous visibility.

JackKelly commented 5 years ago

Hi @sukhbeersingh, thanks loads for doing this!

If you wouldn't mind, please could you swap the video for this new version: https://www.youtube.com/watch?v=IOp-tj-IJpk

(The PV data and satellite data are out-of-sync by an hour in the old video!)

flowirtz commented 5 years ago

Awesome! Thanks for picking it up. I'll aim to review and merge your pr this evening so it's still within hacktoberfest. :-)

sukhbeersingh commented 5 years ago

Hi @FWirtz thanks for your feedback. I put the iframe in a div and added some tailwind style css. Thanks

sukhbeersingh commented 5 years ago

Can we make it a little higher so that it's more like 16:9 dimensions? It feels a little squashed in there imo.

I don't quite know how to. Can you please guide me how to do it? Just to confirm are you talking about the video div itself, or the blackspace inside the video?

flowirtz commented 5 years ago

@all-contributors please add @sukhbeersingh for code

allcontributors[bot] commented 5 years ago

@FWirtz

I've put up a pull request to add @sukhbeersingh! :tada: