search

openclimatefix / website

Source of the Open Climate Fix website.
https://openclimatefix.org
MIT License
15 stars 11 forks source link

Fixes issue 38 - Added Contributors Showcase Component #39

Closed drwm-base closed 4 years ago

drwm-base commented 5 years ago

Fixes Issue #38

I made a component and added it to the Get Involved section of the main page for now. I know you are working on a Get Involved page, so making this a component makes it easy to work with. I had to add gatsby-transform-json to the plugins in order to read the json data, and I created a contributors.json file in src/data in order to store the json data.

flowirtz commented 4 years ago

@drwm-base Amazing!! Thanks so much! I'll give you a review this evening once I'm home, was gone for the weekend.

drwm-base commented 4 years ago

I will address everything here and get back to you asap!

flowirtz commented 4 years ago

Sounds great, no rush please. This isn't urgent.

drwm-base commented 4 years ago

Hey so i fixed some of the issues you brought up, I couldn't get tailwind to work properly, I'm gonna continue to look at it this week. For now, I have a css solution using @media that does what you want it to do without stretching.

drwm-base commented 4 years ago

@FWirtz hey, so I looked into it and I can't really find a solution using tailwind. The core functionality of the grid you wanted is there, and all problems have been resolved. Tailwind is not working because of an issue with compatibility with the .module.css style format used by React. Essentially tailwind works with class names, but the only class name that can be used must be grabbed from the style module.

And the weird scaling on mobile should be fixed.

drwm-base commented 4 years ago

@FWirtz I have applied your changes.