Open achillesrasquinha opened 2 years ago
Attention: Patch coverage is 96.29630%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 84.44%. Comparing base (
7473d13
) to head (eb62c8a
). Report is 67 commits behind head on devel.
Files | Patch % | Lines |
---|---|---|
src/cobra/flux_analysis/variability.py | 96.29% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@Midnighter what about having the progress bar flag in the Configuration. Or having a verbosity flag there?
@Midnighter what about having the progress bar flag in the Configuration. Or having a verbosity flag there?
I think, I would still create a specific progress
parameter for those functions that show a progress bar but just like with Configuration.tolerance
if the argument is unset that could be the default.
Overall, good idea to have it on the configuration. I would not use verbosity, though, because basically people should just create a logging handler with the level that they need.
Okay then maybe continue using the logging level as a default and have the arg in that case.