opencobra / cobrapy

COBRApy is a package for constraint-based modeling of metabolic networks.
http://opencobra.github.io/cobrapy/
GNU General Public License v2.0
467 stars 218 forks source link

feat: add progress to fva #1283

Open achillesrasquinha opened 2 years ago

achillesrasquinha commented 2 years ago
codecov-commenter commented 2 years ago

Codecov Report

Attention: Patch coverage is 96.29630% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.44%. Comparing base (7473d13) to head (eb62c8a). Report is 67 commits behind head on devel.

Files Patch % Lines
src/cobra/flux_analysis/variability.py 96.29% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## devel #1283 +/- ## ========================================== + Coverage 84.40% 84.44% +0.03% ========================================== Files 66 66 Lines 5497 5516 +19 Branches 1265 1267 +2 ========================================== + Hits 4640 4658 +18 Misses 551 551 - Partials 306 307 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cdiener commented 2 years ago

@Midnighter what about having the progress bar flag in the Configuration. Or having a verbosity flag there?

Midnighter commented 2 years ago

@Midnighter what about having the progress bar flag in the Configuration. Or having a verbosity flag there?

I think, I would still create a specific progress parameter for those functions that show a progress bar but just like with Configuration.tolerance if the argument is unset that could be the default.

Overall, good idea to have it on the configuration. I would not use verbosity, though, because basically people should just create a logging handler with the level that they need.

cdiener commented 2 years ago

Okay then maybe continue using the logging level as a default and have the arg in that case.