opencobra / cobrapy

COBRApy is a package for constraint-based modeling of metabolic networks.
http://opencobra.github.io/cobrapy/
GNU General Public License v2.0
467 stars 218 forks source link

fix(core): catch missing reduced costs and shadow prices. #1383

Closed Palaract closed 7 months ago

Palaract commented 8 months ago

This simple code change in the get_solution function in core/solution.py catches all exceptions regarding reduced costs and shadow prices not being available. If the latest change in the downstream dependency optlang (https://github.com/opencobra/optlang/pull/259) is used here, then the general exception can be replaced with a ValueError which would be more specific and still solver agnostic. Still, Exception should catch GurobiErrors as well as ValueErrors and only in the case where those RC and Pi variables are actually accessed, therefore I don't deem it problematic if it would stay like that.

I ran the tests via tox and also tested both minimal working examples of issue numbers #1381 and #1372, both are now working just fine.

Palaract commented 7 months ago

I hope this is concise and correct enough! Thank you for looking into this :)