opencobra / cobratoolbox

The COnstraint-Based Reconstruction and Analysis Toolbox. Documentation:
https://opencobra.github.io/cobratoolbox
Other
246 stars 308 forks source link

Bug in testFVA.m #1593

Open YZ-SJTU opened 4 years ago

YZ-SJTU commented 4 years ago

Hi! I've met a bug when I am running testAll. Something seems error in line 149 in testFVA.m, which is

assert(verifyCobraFunctionError('fluxVariability', 'outputArgCount', 2, ... 'input', {model, 'o', 90, 'rxnNameList', rxnTest}, ... 'testMessage', '''o'' matches multiple parameter names: ''optPercentage'', ''osenseStr''. To avoid ambiguity, specify the complete name of the parameter.'))

I hereby confirm that I have:

(Note: You may replace [ ] with [X] to check the box)

rmtfleming commented 4 years ago
       Hi,

that does not match the devel version

https://github.com/opencobra/cobratoolbox/blob/develop/test/verifiedTests/analysis/testFVA/testFVA.m#L138

inputToTest = {{90, 'max', 'rxnNameList', rxnTest}; ...

            {90, 'osenseStr', 'max', 'rxnNameList', rxnTest,

'allowLoops', 1}; ...

            {'optPercentage', 90, 'rxnNameList', rxnTest}; ...

            {'opt', 90, 'r', rxnTest}};  % test partial matching

On Sun, 10 May 2020 at 12:03, YZ notifications@github.com wrote:

Hi! I've met a bug when I am running testAll. Something seems error in line 149 in testFVA.m, which is

assert(verifyCobraFunctionError('fluxVariability', 'outputArgCount', 2, ... 'input', {model, 'o', 90, 'rxnNameList', rxnTest}, ... 'testMessage', '''o'' matches multiple parameter names: ''optPercentage'', ''osenseStr''. To avoid ambiguity, specify the complete name of the parameter.'))

I hereby confirm that I have:

  • Tried to solve the issue on my own
  • Retried to run my code with the latest version of The COBRA Toolbox
  • Checked that a similar issue has not already been opened

(Note: You may replace [ ] with [X] to check the box)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/opencobra/cobratoolbox/issues/1593, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQMEOWAYLVNDLH5BNMJW4LRQ2CZZANCNFSM4M5GG7WQ .

--

Mr. Ronan MT Fleming B.V.M.S. Dip. Math. Ph.D.

Assistant Professor, Division of Systems Biomedicine and Pharmacology, Leiden Academic Centre for Drug Research, Faculty of Science, Leiden University. https://www.universiteitleiden.nl/en/staffmembers/ronan-fleming & H2020 Project Coordinator, Systems Medicine of Mitochondrial Parkinson’s Disease, http://sysmedpd.eu & Adjunct Lecturer, School of Medicine, National University of Ireland, Galway.

Peer-reviewed publications: https://goo.gl/FZPG23 Mobile: +353 873 413 072 Skype: ronan.fleming

(This message is confidential and may contain privileged information. It is intended for the named recipient only. If you receive it in error please notify me and permanently delete the original message and any copies.)