opencobra / cobratoolbox

The COnstraint-Based Reconstruction and Analysis Toolbox. Documentation:
https://opencobra.github.io/cobratoolbox
Other
247 stars 311 forks source link

bqmodel and bqbiol annotations merged. #2080

Open luciansmith opened 1 year ago

luciansmith commented 1 year ago

Please include a short description of problem here https://github.com/opencobra/cobratoolbox/blob/37c922c422a19d731da66e81059ec0989db39418/src/base/io/utilities/SBML/getBioQualifiers.m

lists several qualifiers in a single list, but some of them come from different lists; see:

https://web.archive.org/web/20211204231945/http://co.mbine.org/specifications/qualifiers

In particular, 'isDerivedFrom', 'isInstanceOf', and 'hasInstance' are in the Model Qualifiers list, but not the Biology Qualifiers list (aka bqmodel but not bqbiol). In addition, 'is' and 'isDescribedBy' are in both lists.

If people feel like these terms should be added to bqbiol in addition to bqmodel, that can probably be done, but in the meantime, it's probably best to put the only-in-bqmodel terms into the accepted namespace.

I hereby confirm that I have:

I looked at the source code and that was it. Issue from https://github.com/sbmlteam/libsbml/issues/283 (cf @GwennyGit).

Thanks!